Upgrade to React 16 + Streaming SSR - #308
Open
Restuta wants to merge 11 commits into
Open
Conversation
… matching peer-dependency to match ract 16
…-inline-react to work with React 16 + set react versions to 16
…" in <div>." error
… width is different from one passed in props
Owner
Author
|
It would be nice to start using React Helmet, but it doesn't support streaming yet :( nfl/react-helmet#322 UPDATE: This lib does https://github.com/staylor/react-helmet-async (https://spectrum.chat/thread/056d029c-99cc-4a54-889c-986497bc5646) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Few things broke as part of this upgrade.
see also this suggestion react/react#10591 (comment)
TL;DR this means