fix: skip startup cursor query - #264
Merged
Merged
Conversation
Contributor
Author
|
just in case, below is the error that happens: ╰─> leaf test.md
^[[1;1RError: The cursor position could not be read within a normal duration |
RivoLink
reviewed
Aug 31, 2026
RivoLink
left a comment
Owner
There was a problem hiding this comment.
Hi,
Thank you for your interest in the project and for this PR.
I have a few requests:
- Fix the CI check failure, may be:
fix: skip startup cursor query - GPG signing is required on the main branch, so if you can sign it, great. If not, no worrie, I'll handle it while preserving you as the author.
GPG signing docs : https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits
Thanks!
AbhiTheModder
force-pushed
the
fix/cursor
branch
from
August 31, 2026 18:13
5be9fa0 to
4f095d5
Compare
Contributor
Author
|
Hi @RivoLink,
|
Owner
|
Hi, I’ve signed the commit. Thanks again for this PR, I really appreciate it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When ratatui 0.30's
terminal.clear()was called right after entering alternate screen mode, the internal get_cursor_position() call sent a `\x1b[6n` (DSR) query that arrived before crossterm's event system was ready, causing a timeout and the raw response^[[1;1Rto appear on screen. Replace it withclear_region(ClearType::All)on the backend directly, which skips the unnecessary cursor save/restore at this point in the startup sequence.