Skip to content

FloatEdit: Visual feedback when out of min/max bounds #1113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
williamchange wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

FloatEdit: Visual feedback when out of min/max bounds #1113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion material_maker/widgets/float_edit/float_edit.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,13 @@ var float_value: float = 0.5

@export var min_value: float = 0.0 :
set(v):
show_hide_out_of_bounds_overlay(float_value < min_value)
min_value = v
$Slider.min_value = v

@export var max_value: float = 1.0 :
set(v):
show_hide_out_of_bounds_overlay(float_value > max_value)
max_value = v
$Slider.max_value = v

Expand Down Expand Up @@ -95,6 +97,8 @@ func set_value(v: Variant, notify := false, merge_undos := false) -> void:
$Slider.value = v
else:
$Slider.value = min_value
show_hide_out_of_bounds_overlay(
float_value < min_value or float_value > max_value)
if notify:
emit_signal("value_changed", float_value)
emit_signal("value_changed_undo", float_value, merge_undos)
Expand All @@ -106,7 +110,6 @@ func set_value(v: Variant, notify := false, merge_undos := false) -> void:
emit_signal("value_changed", v)
emit_signal("value_changed_undo", v, merge_undos)


func set_value_from_expression_editor(v: String) -> void:
if v.is_valid_float():
set_value(float(v), true)
Expand Down Expand Up @@ -329,3 +332,6 @@ func _on_edit_draw() -> void:

if is_focused or is_dragging:
$Edit.draw_style_box(get_theme_stylebox("focus"), Rect2(Vector2(), size))

func show_hide_out_of_bounds_overlay(should_show : bool) -> void:
modulate = Color(1.0,0.9,0.7,1.0) if should_show else Color.WHITE