Change the testing:all prompt to a class option flag (off by default)#195
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the rolemodel:testing:all generator to make the jasmine-playwright runner installation opt-in via a CLI flag, aligning the generator with non-interactive and repeatable install workflows. This also bumps the gem version to reflect the behavior change.
Changes:
- Replace the interactive prompt in
rolemodel:testing:allwith an opt-in--js-runnerclass option (default: off). - Improve generator error handling type for missing GitHub Packages token.
- Update testing generator documentation and bump gem version to
1.3.0.
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/rolemodel/version.rb | Bumps Rolemodel gem version to 1.3.0. |
| lib/generators/rolemodel/testing/README.md | Documents the new --js-runner opt-in behavior for installing jasmine-playwright runner. |
| lib/generators/rolemodel/testing/jasmine_playwright/jasmine_playwright_generator.rb | Uses a Thor exception type for missing token validation. |
| lib/generators/rolemodel/testing/all_generator.rb | Adds --js-runner option and makes jasmine-playwright generator conditional. |
| Gemfile.lock | Updates locked version to 1.3.0. |
| example_rails_legacy/Gemfile.lock | Updates locked version to 1.3.0 in legacy example app. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
wesrich
approved these changes
Jun 30, 2026
|
|
||
| if options.marsh_grass? | ||
| gem 'marsh_grass' | ||
| gem 'pry' |
Contributor
There was a problem hiding this comment.
We shouldn't need this? Pry should be included by the marsh_grass gem if it wants it, but I think we may have gotten rid of that... remind me to check.
Member
Author
There was a problem hiding this comment.
Hey @wesrich check if pry is still a required sibling dependency of marsh grass!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the rolemodel:testing:all generator to make the jasmine-playwright runner installation opt-in via a CLI flag, aligning the generator with non-interactive and repeatable install workflows. This also bumps the gem version to reflect the behavior change.
Changes:
Screenshots