[Refactor] Centralize integration lifecycle transitions - #1651
Draft
roomote-roomote[bot] wants to merge 4 commits into
Draft
[Refactor] Centralize integration lifecycle transitions#1651roomote-roomote[bot] wants to merge 4 commits into
roomote-roomote[bot] wants to merge 4 commits into
Conversation
Contributor
Contributor
Author
|
Resolved in b0431c6: Brain backfill idempotency now checks per-run uniqueness instead of a global insert count that parallel test workers can change, and the follow-up shared-database stress assertion was removed after it proved similarly cross-worker-sensitive. Replacement CI run 32868922402 passed, including the Test job. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why this change was made
Connection persistence previously calculated and emitted the same lifecycle transitions in multiple provider commands and OAuth paths. Centralizing that ownership reduces duplication and prevents integrations from drifting into inconsistent telemetry behavior.
Impact
There is no intended user-facing behavior change. Integration connection and enablement events now reflect independently persisted state transitions, concurrent saves and disables cannot leave an enabled integration without its connection, and the Test CI check no longer depends on a global insert count that parallel workers can change. The main MCP command module is also substantially smaller.