[Fix] Fast automation Run now requests time out - #1659
Draft
roomote-roomote[bot] wants to merge 2 commits into
Draft
[Fix] Fast automation Run now requests time out#1659roomote-roomote[bot] wants to merge 2 commits into
roomote-roomote[bot] wants to merge 2 commits into
Conversation
Contributor
Comment on lines
+721
to
+723
| if ( | ||
| !automation || | ||
| automation.executionMode !== 'fast' || |
Contributor
There was a problem hiding this comment.
This validates the fence and execution mode but not the current enabled value. A Fast automation on a cron schedule can be disabled after run_now returns accepted but before this worker picks up the job; launchCustomAutomationRow bypasses its disabled guard for cron schedules during manual runs, so the queued invocation still sends the external Fast event. Reject and finalize the invocation when the freshly loaded automation is disabled, and add that queued-then-disabled regression case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why this change was made
Manual Fast runs previously held the API request open for the entire agent turn. Runs longer than the worker's two-minute platform API deadline completed successfully on the server but appeared to fail to the caller, making an unsafe duplicate retry likely.
Impact
Fast custom automation runs now acknowledge promptly and remain observable through a durable invocation status. Scheduled automation execution keeps its existing evaluator path, no database migration is required, and the existing settings experience continues to show that the automation is running.