[Improve] Add trial inference choice to setup - #1735
Closed
roomote-roomote[bot] wants to merge 1 commit into
Closed
Conversation
Contributor
Reviewed b5a607c |
![roomote-community[bot]](https://avatars.githubusercontent.com/u/211522643?s=60&v=4){kind=small}
| /> | ||
| ))} | ||
| {step === 'inference' && ( | ||
| <StepConfigureInference |
Contributor
There was a problem hiding this comment.
The new inference choice has no onBack prop or SetupFooter, and this call does not pass one. In the communication-auth flow, inference follows the Slack step, so trial-enabled users can no longer navigate back to Slack from this screen (unlike the replaced provider step). Pass canGoBack ? goToPreviousStep : undefined through and render the Back footer.
Contributor
Author
Contributor
Author
|
Superseded by #1710. The complete setup UI, reviewed trial-inference backend, restored Back navigation, and current validation now live together on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This stacked UI diff was consolidated into #1710 so the feature can be reviewed and merged as one coherent branch without duplicate pull requests.
Why this change was made
Keeping the backend and setup flow together preserves the reviewed security/precedence behavior and avoids merge-order dependencies.
Impact
No work was lost. Continue review on #1710; this draft should not be merged independently.