[Fix] Code review checks remain pending after sandboxes stop - #1741
Draft
roomote-roomote[bot] wants to merge 5 commits into
Draft
[Fix] Code review checks remain pending after sandboxes stop#1741roomote-roomote[bot] wants to merge 5 commits into
roomote-roomote[bot] wants to merge 5 commits into
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why this change was made
PR #1737 exposed a review sandbox that terminated before publishing a result. Several teardown and pre-runtime cancellation paths bypassed the review finalizer, so the canonical summary and GitHub check could remain pending indefinitely.
Impact
Sandbox termination now gives every PR review a terminal GitHub outcome. Successful idle reviews remain completed, explicit stops and non-idle unfinished reviews become canceled, and provider-error recovery behavior for ordinary tasks is unchanged.