docs[installation]: Add CCD sync to test setup instructions - #101
Open
Emrys-Merlin wants to merge 1 commit into
Open
Emrys-Merlin wants to merge 1 commit into
Emrys-Merlin wants to merge 1 commit into
Conversation
I needed to adapt the dev setup instructions when I tried to run the tests locally: 1.) I needed to specify PDB_MIRROR_PATH before running aw setup tests 2.) The downloaded test_pack_latest.tar.gz, did not contain any CCD codes. I fixed the first by setting up the ENV variable. For the second, I ended up running `aw ccd sync test/data/ccd` in the root directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 PR Checklist
This PR is tagged as a draft if it is still under development and not ready for review.
I have ensured that all my commits follow angular commit message conventions.
I have run
make formaton the codebase before submitting the PR (this autoformats the code and lints it).I have named the PR in angular PR message format as well (c.f. above), with a sensible tag line that summarizes all the changes in the PR.
ℹ️ PR Description
Hi :)
I could not follow the dev setup instructions exactly, because I ran into two issues:
aw setup testsfailed if I did not setup the PDB_MIRROR_PATH variable beforehand.aw setup testssuccessfully, ca. half the tests still failed due to missing CCD codes. In fact, notests/data/ccddirectory was created contrary to my expectation. The artifacttest_pack_latest.tar.gzdid not contain any CCD data and the setup code does not seem to try to download the CCDs (in contrast to the missing PDBs).I am not sure if the issue should be addressed on the documentation level or if
aw setup testsshould be adapted (or something else entirely). I thought updating the docs is very low effort. So, I just went ahead. If you prefer to address the issue another way or if I simply made a mistake during setup, I'm happy to close the PR.What changes were made and why?
aw setup tests.aw ccd sync tests/data/ccdto the (new) second point to make sure that CCD data is available.How were the changes tested?
I ran the test suite. Without the changes ca. half the tests failed. After these fixes, all but one1 test passed and the failing test seems unrelated to the downloaded data.
Additional Notes
Footnotes
The failing test is a regression test, namely:
tests/io/components/test_regression.py::test_regression_against_stored_result[1twr]. There was a mismatch in charges for 4 atoms. ↩