widen r * p to u64 in scrypt params bounds check#908
Open
dxbjavid wants to merge 1 commit into
Open
Conversation
Author
|
Hi team, Just checking in on this PR. I wanted to see if there are any updates regarding review or next steps. Please let me know if any further changes are required from my side. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed the final guard in
Params::newcomputesr * pin u32, but both come from a parsed PHC hash string and the earlier checked_mul guards only bound the usize products. On 64-bit, r=65536 p=65536 reaches this line: the u32 multiply wraps to 0, sor * p >= 0x4000_0000is false and scrypt accepts params it must reject (debug builds panic on the overflow instead). Widen both operands to u64 before the compare.