avoid u64 overflow in yescrypt prehash work-factor check#909
Open
dxbjavid wants to merge 1 commit into
Open
Conversation
Author
|
Hi team, Just checking in on this PR. I wanted to see if there are any updates regarding review or next steps. Please let me know if any further changes are required from my side. Thank you! |
Member
|
We'll get to this (and the other PRs you opened on this repo) but these are minor fixes and there are more pressing issues we're currently working on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
yescrypt() gates pre-hashing on
N / p * r >= 0x20000computed in u64. For rw-mode params, N and r aren't bounded here (the rwParamsvalidator checks neither N nor r*p), so a parsed$y$hash with large N and r overflows the multiply and panics in debug builds at lib.rs:96. The check just below at line 127 already uses the division form to dodge this; widen the prehash operands to u128 to match.