Skip to content

Bytecode parity - for-loop cleanup, return duplication, late jump threading fix#7580

Draft
youknowone wants to merge 1 commit intoRustPython:mainfrom
youknowone:bytecode-parity-jump
Draft

Bytecode parity - for-loop cleanup, return duplication, late jump threading fix#7580
youknowone wants to merge 1 commit intoRustPython:mainfrom
youknowone:bytecode-parity-jump

Conversation

@youknowone
Copy link
Copy Markdown
Member

  • Use POP_TOP instead of POP_ITER for for-loop break/return cleanup
  • Expand duplicate_end_returns to clone final return for jump predecessors
  • Restrict late jump threading pass to unconditional jumps only
  • Skip exception blocks in inline/reorder passes
  • Simplify threaded_jump_instr NoInterrupt handling

…eading fix

- Use POP_TOP instead of POP_ITER for for-loop break/return cleanup
- Expand duplicate_end_returns to clone final return for jump predecessors
- Restrict late jump threading pass to unconditional jumps only
- Skip exception blocks in inline/reorder passes
- Simplify threaded_jump_instr NoInterrupt handling
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 10, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 7d9a76c9-91f3-43e4-b88f-33330d0d7e43

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant