Skip to content

chore: Support subpath export in public-api-check#6782

Merged
davidkna-sap merged 2 commits into
mainfrom
davidkna-sap/fix-subpath-public-api-check
Jul 17, 2026
Merged

chore: Support subpath export in public-api-check#6782
davidkna-sap merged 2 commits into
mainfrom
davidkna-sap/fix-subpath-public-api-check

Conversation

@davidkna-sap

@davidkna-sap davidkna-sap commented Jul 17, 2026

Copy link
Copy Markdown
Member

Closes SAP/cloud-sdk-backlog#ISSUENUMBER.

Subpath checks where not supported.
Also tested via SAP/ai-sdk-js#2038

@davidkna-sap
davidkna-sap force-pushed the davidkna-sap/fix-subpath-public-api-check branch from 8a79b72 to c05f691 Compare July 17, 2026 06:42

@marikaner marikaner left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. fmi: where do we use that? or are we planning to use it?

@davidkna-sap

Copy link
Copy Markdown
Member Author

I tried subpath packages in SAP/ai-sdk-js#2038 (mostly for demonstration purposes). I also used them in SAP/ai-sdk-js#2013, but recently I have felt more like it increases technical complexity too much.

@davidkna-sap
davidkna-sap marked this pull request as ready for review July 17, 2026 08:52
@davidkna-sap
davidkna-sap merged commit 3b3294d into main Jul 17, 2026
19 of 20 checks passed
@davidkna-sap
davidkna-sap deleted the davidkna-sap/fix-subpath-public-api-check branch July 17, 2026 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants