Skip to content

fix: remove placeholder setter functions from NewPasswordScreen#1663

Open
dnyaneshwari44 wants to merge 1 commit into
SB2318:mainfrom
dnyaneshwari44:fix/remove-placeholder-setters-1659
Open

fix: remove placeholder setter functions from NewPasswordScreen#1663
dnyaneshwari44 wants to merge 1 commit into
SB2318:mainfrom
dnyaneshwari44:fix/remove-placeholder-setters-1659

Conversation

@dnyaneshwari44

Copy link
Copy Markdown

Description

Removes unused placeholder setter function implementations from src/screens/auth/NewPasswordScreen.tsx.

Changes Made

  • Removed the following placeholder functions:

    • setErrorMessage
    • setPassword
    • setPasswordVerify
  • Removed implementations that contained:

throw new Error('Function not implemented.');
  • Reduced dead code in NewPasswordScreen.tsx.

Rationale

The placeholder functions were not part of the component's active state management logic and should not remain in the codebase. Removing unused stubs improves maintainability and prevents accidental usage in future development.


Type of Change

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Documentation update

Select your work-area

  • Frontend
  • Backend
  • Documentation
  • Others

Related Issue

Closes #1659

Add your Work Example

No UI changes were introduced. This PR only removes unused placeholder implementations.

Checklist

  • I have updated my branch and synced it with the project's develop branch before making this PR.
  • I have optimized the file changes.
  • I have made a PR to the project's develop branch.

Undertaking

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have checked for plagiarism and assure its authenticity.
  • I have read and followed the code of conduct for this repository.
  • I Agree

@github-actions

Copy link
Copy Markdown
Contributor

Thank you @, for creating the PR and contributing to our UltimateHealth project 💗.
Our team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

@github-actions

Copy link
Copy Markdown
Contributor

Automated Review Feedback

No major issues were identified during this review.

The implementation appears consistent with the repository standards and the modified files were reviewed successfully.

Maintainer Note:

Maintainer @SB2318 will review this pull request after the initial automated review cycle is complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace placeholder setter functions in NewPasswordScreen that cause runtime crashes

1 participant