feat: Keyboard Shortcuts (RDFA-365)#181
Open
kiph-soptim wants to merge 7 commits into
Open
Conversation
abba-soptim
requested changes
Jun 16, 2026
abba-soptim
left a comment
abba-soptim
left a comment
Collaborator
There was a problem hiding this comment.
Some general things I have noticed:
- The CTRL+Shift+N shortcut for "New Class" does not work in the Chrome browser. The default behaviour of the hotkey is triggered, which is opening a new incognito window. The shortcut does however function in Firefox.
- The FocusSearch hotkey CTRL+F has weird behaviour with the built-in Search in Document function of web browsers. Pressing the shortcut key once selects and highlights the search bar, but pressing it a second time opens the search function in the browser. Just wanted to point it out, I think completely overwriting the default search function isn't a good idea, so this solution is actually pretty smart. But maybe you have a better idea (unless this was deliberate). Another small thing: the highlight for the search bar is very faint, even though it is not directly part of this story, it would be better to make it more visible (increasing the blue border radius).
- ENTER is still used to accept/save in all dialogs. This makes sense for confirmation dialogs such as the DeleteConfirmDialog, but editor dialogs such as AttributeEditor require a Save action to close the dialog sucessfully. I would suggest reusing the CTRL+S shortcut here, consistent with saving a class. Another idea would be to allow it as well as the normal ENTER shortcut.
| */ | ||
| function normalizeEvent(event) { | ||
| const key = event.key.toLowerCase(); | ||
| const isSpecialChar = key.length === 1 && !/[a-z0-9]/.test(key); |
Collaborator
There was a problem hiding this comment.
I understand the need for this, but this also fires for shortcuts like "CTRL+-". This might lead to unexplainable behaviour down the line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added Shortcut dialog.
Added the following shortcuts
Ctrl+ICtrl+ECtrl+Shift+ICtrl+Shift+ECtrl+Shift+SCtrl+SCtrl+Shift+NCtrl+Alt+NCtrl+Shift+KCtrl+Alt+RCtrl+Shift+ACtrl+Alt+PCtrl+Shift+CCtrl+Shift+HCtrl+Shift+MCtrl+Shift+LCtrl+F?Ctrl+Alt+SRelated Issues
Checklist
git commit -s) for DCOTesting Notes