Feature/fred yf integration#5
Merged
Merged
Conversation
…pyproject.toml and requirements.txt and yfinance dependency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added yfinance dependency. Added a new function and client for integration with FRED API and yfinance for data pulling outside of the ClickHouse DB. Opted for a separate function approach as the parameters for the ClickHouse query function were sq-oriented and too different in nature.
All existing applications using DataLoader will remain the same and work as intended. These applications can have a simple conditional statement outside of DataLoader that also queries DataLoader using the Fred + YF function if the ClickHouse DB does not have the necessary data. When Clickhouse DB is updated, no logic will need to change.