🧹 Remove unused MDX frontmatter fields: createdByEmail and lastUpdatedByEmail - Closes #2654#2655
Draft
github-actions[bot] wants to merge 1 commit into
Draft
Conversation
- Remove createdByEmail field from TinaCMS schema (createdInfoFields.ts) - Remove lastUpdatedByEmail field from TinaCMS schema (historyFields.ts) - Stop writing lastUpdatedByEmail in historyBeforeSubmit - Remove createdByEmail default value from rule.tsx defaultItem - Remove createdByEmail and lastUpdatedByEmail from GraphQL queries (queries.gql) - Remove fields from category API types (CategoryFullQueryResponse, CategoryMutationParams) - Remove fields from category GraphQL queries in constants.ts - Remove fields from buildCategoryParams in update-the-category-rule-list.ts - Simplify UserInfoField to always use fullName (email branch now dead code) - Update tina-lock.json to reflect schema changes Closes #2654 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the unused
createdByEmailandlastUpdatedByEmailfrontmatter fields from the app repo as requested in #2654. These fields were write-only — they were stored in MDX frontmatter but never read by the UI or business logic.Changes
TinaCMS Schema
tina/collection/shared/createdInfoFields.ts: Removed thecreatedByEmailfield definitiontina/collection/shared/historyFields.ts: Removed thelastUpdatedByEmailfield definition; removeduserEmailvariable and all writes tolastUpdatedByEmailinhistoryBeforeSubmitRule Collection
tina/collection/rule.tsx: RemovedcreatedByEmail: "Unknown"fromdefaultItemUserInfoField Component
tina/fields/UserInfoField.tsx: Simplified the branch that resolvedcreatedByEmail→ email vscreatedBy→ fullName; now always resolves tofullNamesincecreatedByEmailno longer existsGraphQL Queries
tina/queries/queries.gql: RemovedcreatedByEmailandlastUpdatedByEmailfrom bothruleDataandruleDataBasicqueriesCategory Update API
app/api/update-category/types.ts: RemovedcreatedByEmailandlastUpdatedByEmailfromCategoryFullQueryResponseandCategoryMutationParamsapp/api/update-category/constants.ts: Removed fields fromCATEGORY_FULL_QUERYandCATEGORY_FULL_QUERY_NO_INDEXGraphQL queriesapp/api/update-category/update-the-category-rule-list.ts: RemovedcreatedByEmailandlastUpdatedByEmailfrombuildCategoryParamsGenerated Files
tina/tina-lock.json: Updated to remove field entries for bothcreatedByEmailandlastUpdatedByEmailAcceptance Criteria Coverage
createdByEmailandlastUpdatedByEmailremoved from TinaCMS schema/configSSW.Rules.Content— tracked as follow-up per the issueNotes
The content repo cleanup (removing existing frontmatter values from MDX files in
SSW.Rules.Content) should be done as a follow-up after this PR is merged, as the app no longer depends on these fields.Closes #2654