Skip to content

Retirement ux warning states#129

Open
jenbreese wants to merge 1 commit into
devfrom
retirement-ux-warning-states
Open

Retirement ux warning states#129
jenbreese wants to merge 1 commit into
devfrom
retirement-ux-warning-states

Conversation

@jenbreese

Copy link
Copy Markdown
Collaborator

READY FOR REVIEW

Summary

  • Fixes documented in the UX&Warning states document.

Review By (Date)

  • next week

Criticality

  • normal

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Navigate to the document of list.
  3. Verify the resolved ones are fixed

Front End Validation

  • Is the markup using the appropriate semantic tags and passes HTML validation?
  • Cross-browser testing has been performed?
  • Automated accessibility scans performed?
  • Manual accessibility tests performed?
  • Design is approved by @ user?

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

  • JIRA ticket(s)
  • Other PRs
  • Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
  • Anyone who should be notified? (@mention them here)

Resources

@jenbreese jenbreese changed the base branch from 1.x to dev June 13, 2026 00:01
@jenbreese jenbreese requested a review from imonroe June 13, 2026 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant