Refactor rotation matrix alignment - #342
Open
Ryukon07 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rotation_matrix_from_vectorcurrently implements vector alignment with manual cross-product algebra. This replaces that implementation with SciPy's existingRotation.align_vectorsutility while preserving the package's optional-SciPy import behavior.The focused tests cover vectors both parallel and antiparallel to each target axis, require a proper rotation with determinant
+1, and verify the missing-SciPy error.Validation:
pytest -q tests/test_rotation.py(3 passed)ruff check .ruff format --check .python -m numpydoc lint swiftsimio/optional_packages.py swiftsimio/visualisation/rotation.py tests/test_rotation.pygit diff --check6.699e-14, orthogonality error1.221e-15, determinant error1.554e-15The broader rotation/visualisation selection was intermittent locally: its parallel volume-render exact-equality case failed in some Python 3.12 and 3.14 runs and passed in later default-thread and single-thread reruns. Direct probes using both the old and new rotation implementations also produced exact render matches, so I could not establish a deterministic regression.
Closes #309