Inspect App - #116
Merged
Merged
Conversation
JonasScholl
marked this pull request as ready for review
July 9, 2026 13:06
JonasScholl
marked this pull request as draft
July 9, 2026 13:07
JonasScholl
marked this pull request as ready for review
July 16, 2026 14:21
…rt' and 'import from'' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
…6.2.0 add new driver schema (pre version 2026.2.0)
…ipath instance version
Member
Author
|
I have finished all my tasks and incorporated the feedback. From my end, it is ready to be merged. |
Review: Inspect App Integration
Collaborator
|
@JonasScholl |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
app.inspect, a new read/write interface to VideoIPath's Inspect surface (verified against 2025.4+). It is purely additive,app.topologyandapp.inventoryare unchanged.Inspect lets you:
add_devices_to_topology,sync_devices,get_sync_info)Key design choices
nGraphElements/edgesByDevice(ADR-0008)rebase()to retry (ADR-0009)The snapshot is an internal implementation detail. Users interact only through
app.inspect, not a snapshot object.What's included
Application code
src/videoipath_automation_tool/apps/inspect/InspectApp(read / write / actions mixins)InspectAPI+ typed Pydantic modelsInspectSnapshotwith lazy hydration and in-memory indexesInspectTransactionwith compare-and-commit conflict detectionInspectDevice,InspectModule,InspectPort,InspectVertex,InspectEdge,InspectServiceVideoIPathAppas a lazyapp.inspectproperty (also exposed as_inspect_apiinDEVmode)Tests
tests/inspect/): Offline, fixture-driven coverage for snapshot loading, queries, transactions, conflict handling, and API parsing (anonymized 2025.4.9 fixtures)tests/e2e/): Developer-run locally only against a real instance; focused app suites underapps/(including Inspect) and ordered cross-app workflows underworkflows/. Artifacts areE2E-namespaced and cleaned by a session-start sweeppoetry run test-unit,poetry run test-e2e,poetry run testtest-unit(e2e excluded by default via pytest marker)Documentation
docs/getting-started-guide/03_B_Inspect.mddocs/architecture/inspect-app/(concepts, models, endpoints, 10 ADRs)docs/architecture/future/unified-domain-architecture.mdTooling / housekeeping
.env.templatereplaces.env.example(e2e connection vars documented there)AGENTS.mdand path-scoped Python agent rules (.claude/rules/,.cursor/rules/symlinks)