feat: 9주차 미션_제로#64
Open
jeongkyueun wants to merge 9 commits into
Open
Conversation
Lemon0610
reviewed
May 27, 2026
Comment on lines
+145
to
+188
| private fun QuickMenuSection() { | ||
| val items = listOf( | ||
| QuickMenuItem(R.drawable.ic_order, "주문"), | ||
| QuickMenuItem(R.drawable.ic_identificationcard, "패스"), | ||
| QuickMenuItem(R.drawable.ic_event, "이벤트"), | ||
| QuickMenuItem(R.drawable.ic_setting, "설정") | ||
| ) | ||
|
|
||
| Row( | ||
| modifier = Modifier | ||
| .fillMaxWidth() | ||
| .height(IntrinsicSize.Min) | ||
| .padding(vertical = 20.dp) | ||
| ) { | ||
| items.forEachIndexed { index, item -> | ||
| if (index > 0) { | ||
| VerticalDivider( | ||
| modifier = Modifier | ||
| .fillMaxHeight() | ||
| .padding(vertical = 4.dp), | ||
| color = colorResource(id = R.color.border_gray) | ||
| ) | ||
| } | ||
| Column( | ||
| modifier = Modifier.weight(1f), | ||
| horizontalAlignment = Alignment.CenterHorizontally, | ||
| verticalArrangement = Arrangement.Center | ||
| ) { | ||
| Icon( | ||
| painter = painterResource(id = item.iconRes), | ||
| contentDescription = item.label, | ||
| modifier = Modifier.size(26.dp), | ||
| tint = Color.Unspecified | ||
| ) | ||
| Spacer(modifier = Modifier.height(4.dp)) | ||
| Text( | ||
| text = item.label, | ||
| fontSize = 12.sp, | ||
| color = colorResource(id = R.color.nike_black) | ||
| ) | ||
| } | ||
| } | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
아이콘과 글씨 크기들을 더 키워도 좋을 것 같아요!
mookeunji05
reviewed
May 27, 2026
| @@ -1 +1 @@ | |||
| package com.example.week2 | |||
Collaborator
There was a problem hiding this comment.
저는 MainActivity 에 모든 스크린을 몰아넣었는데, 제로님은 분리해서 작성한 점이 가독성을 높이는 것 같습니다.
sua710
reviewed
May 27, 2026
Comment on lines
+9
to
+21
| interface ReqResService { | ||
| @GET("api/users/{id}") | ||
| suspend fun getUser( | ||
| @Path("id") id: Int, | ||
| @Header("x-api-key") apiKey: String = BuildConfig.REQRES_API_KEY | ||
| ): Response<UserResponse> | ||
|
|
||
| @GET("api/users") | ||
| suspend fun getUsers( | ||
| @Query("page") page: Int = 1, | ||
| @Header("x-api-key") apiKey: String = BuildConfig.REQRES_API_KEY | ||
| ): Response<UserListResponse> | ||
| } |
Collaborator
There was a problem hiding this comment.
ReqRes API 호출부를 getUser, getUsers로 분리하신거 좋아요!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 feat: 9주차 미션_제로
🔗 관련 이슈
Closes #62
✨ 변경 사항
ReqRes API를 활용해 유저 1번의 프로필 정보를 불러옵니다.
HorizontalPager(
state = pagerState,
pageSize = PageSize.Fixed(90.dp), // 한 화면에 여러 유저가 보임
contentPadding = PaddingValues(horizontal = 20.dp),
pageSpacing = 8.dp
) { page ->
FollowingAvatar(user = following[page]) // 원형 이미지 + 이름
}
PageSize.Fixed로 각 페이지 너비를 고정해 한 화면에 4개의 유저가 동시에 보이며, 스와이프로 다음 유저로 이동합니다.
API 키를 소스코드에 하드코딩하지 않고 local.properties + BuildConfig로 관리합니다.
🔍 테스트
📸 스크린샷 (선택)
🚨 추가 이슈