Feat: 9주차 미션_묵은지#65
Open
mookeunji05 wants to merge 26 commits into
Open
Conversation
Lemon0610
reviewed
May 27, 2026
Comment on lines
+24
to
+36
| @GET("api/users/{id}") | ||
| suspend fun getUser( | ||
| @Path("id") id: Int, | ||
| @Header("x-api-key") | ||
| apiKey: String = "reqres_3fd0bc2b94a34359a2e2b56a6f1f7d85" | ||
| ): UserResponse | ||
|
|
||
| @GET("api/users") | ||
| suspend fun getUsers( | ||
| @Query("page") page: Int = 2, | ||
| @Header("x-api-key") | ||
| apiKey: String = "reqres_3fd0bc2b94a34359a2e2b56a6f1f7d85" | ||
| ): UserListResponse |
Collaborator
There was a problem hiding this comment.
이거 아마 하나로 합칠 수 있을 것 같아요! 어차피 1번이 사용자인거니까 그것만 따로 걸러주면 될 것 같아요.
sua710
reviewed
May 27, 2026
Comment on lines
+24
to
+37
| @GET("api/users/{id}") | ||
| suspend fun getUser( | ||
| @Path("id") id: Int, | ||
| @Header("x-api-key") | ||
| apiKey: String = "reqres_3fd0bc2b94a34359a2e2b56a6f1f7d85" | ||
| ): UserResponse | ||
|
|
||
| @GET("api/users") | ||
| suspend fun getUsers( | ||
| @Query("page") page: Int = 2, | ||
| @Header("x-api-key") | ||
| apiKey: String = "reqres_3fd0bc2b94a34359a2e2b56a6f1f7d85" | ||
| ): UserListResponse | ||
| } |
Collaborator
There was a problem hiding this comment.
getUsers의 기본 page가 2로 고정되어 있는데, 호출부에서 명시적으로 넘기거나 기본값을 1로 두면 API 동작을 더 예측하기 쉬울 것 같습니다!
jeongkyueun
approved these changes
May 27, 2026
|
|
||
| object RetrofitClient { | ||
|
|
||
| private const val BASE_URL = "https://reqres.in/" |
Collaborator
There was a problem hiding this comment.
BASE_URL이 하드코딩 되어 있는데 보완 관점에서 추후에 local.properties 통해 buildconfig로 관리하면 좋을 거 같아요 !!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 PR 제목
🔗 관련 이슈
Closes #이슈번호
✨ 변경 사항
🔍 테스트
📸 스크린샷 (선택)
🚨 추가 이슈