9주차 미션 [이서]#37
Open
seoyoon127 wants to merge 14 commits into
Open
Conversation
…Boot_A into leeseo/week9
yangjiae12
approved these changes
May 27, 2026
| AccessDeniedException accessDeniedException | ||
| ) throws IOException, ServletException { | ||
| ObjectMapper objectMapper = new ObjectMapper(); | ||
| BaseErrorCode code = GeneralErrorCode.UNAUTHORIZED; |
Member
There was a problem hiding this comment.
AccessDeniedHandler는 인증은 되었지만 권한이 부족한 경우에 동작하므로, 401보다는 403 응답을 내려주는 것이 더 적절해 보입니다! AuthenticationEntryPoint는 401, AccessDeniedHandler는 403으로 역할을 분리하면 좋을 것 같습니다~
Comment on lines
+61
to
+63
| } catch (Exception e) { | ||
| ObjectMapper mapper = new ObjectMapper(); | ||
| BaseErrorCode code = GeneralErrorCode.UNAUTHORIZED; |
Member
There was a problem hiding this comment.
JwtAuthFilter에서 모든 예외를 Exception으로 잡고 있어 예상치 못한 서버 오류도 401로 처리될 수 있을 것 같습니다. JWT 관련 예외나 인증 실패 예외처럼 처리할 예외 범위를 조금 더 명확히 나누면 좋을 것 같습니다!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚩 관련 이슈
📌 구현 결과
JWT 토큰 방식의 회원가입, 로그인 구현
마이페이지 개선
JWT + OAuth 구현
❓ 리뷰 요청
🤔 질문
💬 기타 공유 사항