fix: handle chapter display and nibbles for late-start playback#765
fix: handle chapter display and nibbles for late-start playback#765Roze061 wants to merge 5 commits into
Conversation
|
Looks good to me. I see you changed the status to a draft. Are you still working on something? |
|
@Samillion will using |
You mean in Could you explain the problem in more detail? As just replacing |
|
|
|
Wouldn't a change in the layouts for chapter be better?
--local chapter_index = user_opts.show_chapter_title and (state.chapter or -1) >= 0
++local chapter_index = user_opts.show_chapter_title and #state.chapter_list > 0 and (state.chapter or -1) >= 0
--local chapter_index = (state.chapter or -1) >= 0
++local chapter_index = #state.chapter_list > 0 and (state.chapter or -1) >= 0In fact, both layouts should be this instead: local chapter_index = #state.chapter_list > 0 and (state.chapter or -1) >= 0 |
|
state.chapter is "-1" when chapter not start at 0, if not |
|
Indeed. I don't see a problem with using Could you also make the change to local chapter_index = #state.chapter_list > 0 and (state.chapter or -1) >= 0 |
|
(chapter: use request_init instead of #chapter_list)chapter: use request_init instead of #chapter_list |
FIX #764