Skip to content

Harden GC container safety, fix origin/postMessage spec bugs, minor perf cleanups - #1

Open
fadelhbr wants to merge 1 commit into
Samsung:masterfrom
fadelhbr:bug-fix
Open

fadelhbr wants to merge 1 commit into
Samsung:masterfrom
fadelhbr:bug-fix

Conversation

@fadelhbr

Copy link
Copy Markdown

replace std vector with GCVector for GC managed pointer containers
across layout, mediasource, worker, and CDP dispatcher to prevent
collected elements from being accessed through non GC heap buffers.

inline GridLine members in GridArea was 4 heap allocs per instance.

return performance, getEntries() by const ref to avoid vector copy.

fix two distinct opaque origins are never same origin per HTML spec, only identical object identity passes.

enforce postMessage targetOrigin check per HTML, drop message when receiver origin does not match the requested targetOrigin.

remove pagePopupController from WindowProxy allowlist.

across layout, mediasource, worker, and CDP dispatcher to prevent
collected elements from being accessed through non GC heap buffers.

inline GridLine members in GridArea was 4 heap allocs per instance.

return performance, getEntries() by const ref to avoid vector copy.

fix two distinct opaque origins are never same origin per HTML spec,
only identical object identity passes.

enforce postMessage targetOrigin check per HTML, drop message when
receiver origin does not match the requested targetOrigin.

remove pagePopupController from WindowProxy allowlist.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant