[Dev] Drop has_internal_collective from magi_register_custom_op - #58
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗂️ PR Category
📝 Description
Drop
has_internal_collectivefrommagi_register_custom_op. Every op registered through the decorator is now treated as lockstep-replay (has_internal_collective=True): seeded in__call__, measured inwarm_and_syncwith fixed iters, and included in the FSDP-overlap collective skeleton.Call sites that passed
has_internal_collective=Trueshould just delete the argument. The low-levelregister_materialize_inputs(..., has_internal_collective=)flag is unchanged.