Conversation
Agent-Logs-Url: https://github.com/SasView/sasview.github.io/sessions/4f1bc8bf-3762-4c86-89c9-e0c4fe440f64 Co-authored-by: butlerpd <10955478+butlerpd@users.noreply.github.com>
butlerpd
left a comment
butlerpd
left a comment
There was a problem hiding this comment.
Looking at this directory, it does not in fact seem to be a legacy folder. In fact, it is the folder that contains all the artifacts that can be retrieved directly from the webpages. Thus it has a different purpose than the downloads page. The readme file is clearly meant to give developers information about the purpose of the folder and probably best not to remove that information.
What is not clear to me is why sasview.org/downloads renders as an actual page while attempts to access other directories, for example sasview.org/img thows a 404 error?
Somehow that readme information should be kept in a way that is obvious to developers navigating to the directory while throwing a 404 error for anyone attempting to navigate from the web to sasview.org/downloads though redirecting that to the links and download page works too. Not sure how one does that but...
Agent-Logs-Url: https://github.com/SasView/sasview.github.io/sessions/4c3b0d45-38de-4fb4-b7bb-b79840f70ae8 Co-authored-by: butlerpd <10955478+butlerpd@users.noreply.github.com>
Good point — I've restored the original developer notes back into the file (commit As for why |
There was a problem hiding this comment.
Pull request overview
This PR addresses an unintended/stale /downloads page generated by Jekyll from downloads/README.md by turning that README into an immediate client-side redirect to the canonical /download downloads page.
Changes:
- Added Jekyll front matter to
downloads/README.mdso it is rendered as a page. - Added an immediate redirect to
/download(JS) with a meta refresh + clickable link fallback. - Preserved the original developer notes below the redirect content.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| --- | ||
| layout: page | ||
| title: Redirecting... | ||
| --- | ||
|
|
||
| <script>window.location.replace("/download");</script> | ||
| <meta http-equiv="refresh" content="0; url=/download"> | ||
| <p>This page has moved. Please <a href="/download">click here</a> if you are not redirected automatically.</p> |
There was a problem hiding this comment.
Done in ed27373. Switched to layout: null so the page is now a complete minimal HTML document — the <meta http-equiv="refresh"> and <script> redirect both fire from <head> before any layout assets are requested. The URL also now uses the trailing slash /download/ throughout to avoid the extra 301 hop. Developer notes are preserved in an HTML comment at the end of the file.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Agent-Logs-Url: https://github.com/SasView/sasview.github.io/sessions/ddbc860e-af97-4924-96cb-e1d508843d8a Co-authored-by: butlerpd <10955478+butlerpd@users.noreply.github.com>
butlerpd
left a comment
butlerpd
left a comment
There was a problem hiding this comment.
this now looks good to me. Should be ready to merge
The
downloads/README.mdwas being rendered by Jekyll as a page at/downloads, surfacing stale leftover content to users arriving via search engines. The canonical downloads page lives at/download/.Changes
layout: null—downloads/README.mdis now a complete, self-contained HTML document. The<meta http-equiv="refresh">and JS redirect both fire from<head>before any layout CSS/JS assets are requested.replace,metarefresh, fallback link) point to/download/to avoid an extra 301 hop on GitHub Pages.<link rel="canonical" href="/download/">added in<head>.downloads/remain accessible at their existing paths.