Skip to content

fix: handle transitive dependencies in TreeScope - #748

Open
seraphr wants to merge 3 commits into
ScalablyTyped:masterfrom
kurusugawa-computer:bugfix/aws-middleware-s3_for-upstream
Open

seraphr wants to merge 3 commits into
ScalablyTyped:masterfrom
kurusugawa-computer:bugfix/aws-middleware-s3_for-upstream

Conversation

@seraphr

@seraphr seraphr commented Apr 23, 2026

Copy link
Copy Markdown

Summary

This PR fixes #747, where converting @aws-sdk/middleware-sdk-s3 generated Scala code that failed to compile with an inherits conflicting members error.

The root cause was that TreeScope only considered direct dependencies. In this case, methods inherited through transitive dependencies were not visible during generation, so the converter emitted members such as serializeRequest without recognizing that they should override an inherited definition.

Changes

  • add a reproduction test for aws-middleware-s3
  • resolve transitive Scala.js dependencies when building TreeScope

Result

With the transitive dependency graph available during generation, the converter no longer emits the conflicting member definition for S3RestXmlProtocol

Closes #747.

@seraphr seraphr changed the title fix: handle transitive Scala.js dependencies in TreeScope fix: handle transitive dependencies in TreeScope Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@aws-sdk/middleware-sdk-s3 3.972.28 causes inherits conflicting members

1 participant