Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #747, where converting
@aws-sdk/middleware-sdk-s3generated Scala code that failed to compile with aninherits conflicting memberserror.The root cause was that
TreeScopeonly considered direct dependencies. In this case, methods inherited through transitive dependencies were not visible during generation, so the converter emitted members such asserializeRequestwithout recognizing that they should override an inherited definition.Changes
aws-middleware-s3TreeScopeResult
With the transitive dependency graph available during generation, the converter no longer emits the conflicting member definition for
S3RestXmlProtocolCloses #747.