optimize ConversationStateService

[yileicn]

No description provided.

[qodo-code-review]

Review Summary by Qodo

Add read-only mode support to ConversationStateService

✨ Enhancement

Walkthroughs

Description

• Add _isReadOnly flag to track read-only state
• Prevent state persistence when conversation loaded in read-only mode
• Simplify conversation ID assignment logic

Diagram

flowchart LR
  Load["Load method"] -->|"set _isReadOnly flag"| ReadOnlyFlag["_isReadOnly field"]
  ReadOnlyFlag -->|"check in Save"| SaveMethod["Save method"]
  SaveMethod -->|"skip persistence"| Prevention["Prevent state save"]

Loading

File Changes

1. src/Infrastructure/BotSharp.Core/Conversations/Services/ConversationStateService.cs ✨ Enhancement +4/-2

Implement read-only mode with state persistence guard

• Added _isReadOnly private field to track read-only state
• Modified Load method to set _isReadOnly flag and always assign conversationId
• Updated Save method to check _isReadOnly flag and skip persistence when true
• Simplified conversation ID assignment by removing conditional null assignment

src/Infrastructure/BotSharp.Core/Conversations/Services/ConversationStateService.cs

---

[qodo-code-review]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

ⓘ The new review experience is currently in Beta. Learn more

[Copilot]

Pull request overview

This PR refines ConversationStateService’s read-only behavior so the service can still expose a valid ConversationId while ensuring state persistence is skipped when operating in read-only mode.

Changes:

• Introduced an internal _isReadOnly flag to track read-only loads.
• Updated Load to always set _conversationId (even in read-only mode).
• Updated Save to short-circuit when the service is in read-only mode.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.