Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tests/e2e/test_reranking_e2e.py only sets the asyncio mark at module level, so its two tests never carry the e2e mark.
That has two effects. The e2e workflow runs
pytest tests/e2e/ -m e2e, so both reranking tests get deselected there and never run. And a plain local pytest (pytest.ini adds -m "not e2e") picks them up, even though they need Postgres in Docker.The change uses the same module-level pytestmark list as test_file_tools_e2e.py and test_auto_link_threshold_e2e.py.
Checked locally: on main, -m e2e over tests/e2e/ deselects these two tests. With the change, the default run deselects them, -m e2e collects them, and both pass on my fork against forgetful-db.