Docs update for developers - #1085
Merged
Merged
Conversation
The geoengine document stopped at the pedestrian map matcher, which left the whole of the travel work undescribed. Add three sections covering it. Features along a Way explains AlongWayFeature: why crossings, transit stops and railway stops are hung on the Way they belong to rather than found by searching near the user, and why each attach pass runs where it does - waterway crossings per tile, railway crossings only once the grid is merged, since a road and a railway can straddle a tile boundary at the point they cross. It also states plainly that highway=crossing is not one of these, because the naming invites the opposite assumption. Rail map matching covers the second network, the two MapMatchFilter instances, and RailMatchArbiter's reasons for making a ride harder to acquire than to hold. Travel mode covers the derived predicates, the callout builders, the reverse geocode precedence and the sticky windows. StationaryDetector gets its own section with the measured thresholds. Correct the MapMatchFilter section too: it said the filter runs on the filtered location, but both matchers are fed the unfiltered flow. Also fix three comments referring to AutoCallout.buildCalloutForTrainStop, which no longer exists - the station lookup is namedStationWithin. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01THRgoVbh1G3pVacd7csDqJ
The list of changes we've made to planetiler-openmaptiles had five entries and was missing most of the last year's work, so replace it with a full inventory grouped by layer: the extra transportation attributes (name, ref, tunnel_name, junction, footway), pedestrian crossing points, rail stop nodes from all three taggings, bay and strait polygons and lines, water polygon names, POI polygons, entrances, NAPTAN, and the address tags on both the poi and housenumber layers. Also describe what the openmaptiles fork does, which was previously a single sentence - it is where the tags are let through to the Java in the first place, and the POI mappings there are now wildcards rather than allow-lists. Correct the zoom level throughout. We build at 14 rather than 15 now, so the tile is 2446m square at 60cm resolution rather than 1223m at 30cm, and the customizations are written against config.maxzoom() rather than a hard-coded 15 so that the level is a build argument. The layer list was wrong too - it named protomaps basemap layers rather than the OpenMapTiles ones we get. Bring the build instructions up to date with the soundscape-maps scripts, including the planet build only rebuilding when OSM publish a new file. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01THRgoVbh1G3pVacd7csDqJ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.