Upcoming release v1.1.0 by SebiTimeWaster · Pull Request #3 · SebiTimeWaster/Public-Teleport

SebiTimeWaster · 2026-09-15T12:51:10Z

Release Notes:

Added Feature: Portals that teleport a player to any dimension or redirects to another Minecraft server when walked into
The command '/spawn' now uses the Minecraft world spawn as a fallback if the spawn target was not set with /setspawn
Code cleanup, added Github actions

…et was not set by '/setspawn'

github-actions · 2026-09-15T13:18:31Z

✅ Duplicate Code Report

Two engines run in parallel for cross-validation. Each has its own thresholds tuned to its baseline - the real safety net is the per-engine "max increase vs base" check.

✅ PMD CPD

	PR	Base	Change
Clones	6	9	🙂 -3
Duplicated lines	86	162	❤️ -76
Duplication	2.97%	5.60%	❤️ -2.63%

Rule	Limit	Status
Max duplication	5%	✅ Pass (2.97%)
Max increase vs base	+0.1%	✅ Pass (-2.63%)

⚠️ 6 new clones introduced

15 lines (48 tokens): src/main/java/timewaster/publicteleport/Teleports.java:142 <-> src/main/java/timewaster/publicteleport/Teleports.java:189
9 lines (47 tokens): src/main/java/timewaster/publicteleport/Requests.java:206 <-> src/main/java/timewaster/publicteleport/Requests.java:244
5 lines (42 tokens): src/main/java/timewaster/publicteleport/Storage.java:408 <-> src/main/java/timewaster/publicteleport/Storage.java:439
4 lines (41 tokens): src/main/java/timewaster/publicteleport/commands/Warps.java:32 <-> src/main/java/timewaster/publicteleport/commands/Warps.java:78
4 lines (37 tokens): src/main/java/timewaster/publicteleport/Registrar.java:197 <-> src/main/java/timewaster/publicteleport/Registrar.java:223
6 lines (37 tokens): src/main/java/timewaster/publicteleport/Storage.java:327 <-> src/main/java/timewaster/publicteleport/Storage.java:377

✅ jscpd (language-agnostic)

	PR	Base	Change
Clones	19	16	🫤 +3
Duplicated lines	123	140	👍 -17
Duplication	4.25%	6.70%	❤️ -2.45%

Rule	Limit	Status
Max duplication	5%	✅ Pass (4.25%)
Max increase vs base	+0.1%	✅ Pass (-2.45%)

⚠️ 19 new clones introduced

4 lines: src/main/java/timewaster/publicteleport/commands/Warps.java:78 <-> src/main/java/timewaster/publicteleport/commands/Warps.java:32
8 lines: src/main/java/timewaster/publicteleport/commands/Tpa.java:6 <-> src/main/java/timewaster/publicteleport/commands/Warps.java:9
8 lines: src/main/java/timewaster/publicteleport/commands/Spawn.java:3 <-> src/main/java/timewaster/publicteleport/commands/Warps.java:9
4 lines: src/main/java/timewaster/publicteleport/commands/Portals.java:5 <-> src/main/java/timewaster/publicteleport/commands/Warps.java:3
6 lines: src/main/java/timewaster/publicteleport/commands/Homes.java:1 <-> src/main/java/timewaster/publicteleport/commands/Warps.java:1
19 lines: src/main/java/timewaster/publicteleport/commands/Homes.java:7 <-> src/main/java/timewaster/publicteleport/commands/Warps.java:7
3 lines: src/main/java/timewaster/publicteleport/commands/Homes.java:101 <-> src/main/java/timewaster/publicteleport/commands/Warps.java:91
8 lines: src/main/java/timewaster/publicteleport/commands/Help.java:9 <-> src/main/java/timewaster/publicteleport/commands/Warps.java:9
9 lines: src/main/java/timewaster/publicteleport/commands/Back.java:1 <-> src/main/java/timewaster/publicteleport/commands/Warps.java:9
7 lines: src/main/java/timewaster/publicteleport/Teleports.java:3 <-> src/main/java/timewaster/publicteleport/commands/Portals.java:3
15 lines: src/main/java/timewaster/publicteleport/Teleports.java:189 <-> src/main/java/timewaster/publicteleport/Teleports.java:142
4 lines: src/main/java/timewaster/publicteleport/TeleportSafety.java:13 <-> src/main/java/timewaster/publicteleport/commands/Portals.java:30
9 lines: src/main/java/timewaster/publicteleport/Storage.java:375 <-> src/main/java/timewaster/publicteleport/Storage.java:325
5 lines: src/main/java/timewaster/publicteleport/Storage.java:439 <-> src/main/java/timewaster/publicteleport/Storage.java:408
8 lines: src/main/java/timewaster/publicteleport/Requests.java:1 <-> src/main/java/timewaster/publicteleport/commands/Portals.java:3
9 lines: src/main/java/timewaster/publicteleport/Requests.java:244 <-> src/main/java/timewaster/publicteleport/Requests.java:206
6 lines: src/main/java/timewaster/publicteleport/Registrar.java:75 <-> src/main/java/timewaster/publicteleport/commands/Portals.java:267
5 lines: src/main/java/timewaster/publicteleport/Registrar.java:223 <-> src/main/java/timewaster/publicteleport/Registrar.java:197
5 lines: src/main/java/timewaster/publicteleport/Portals.java:9 <-> src/main/java/timewaster/publicteleport/Utils.java:11

_{Powered by astubbs/duplicate-code-cross-check}

github-actions · 2026-09-15T13:33:40Z

                    return false;
                }

                Teleport target = Teleport.create(player, argValue);


⚠️ Duplicate code detected - 15 lines duplicated with src/main/java/timewaster/publicteleport/commands/Homes.java:58

github-actions · 2026-09-15T13:33:41Z

@@ -296,7 +306,7 @@ public Boolean setTeleport(ServerPlayer player, Teleport newTeleport, boolean is
        int numTeleports = 0;

        if (teleports == null) {


⚠️ Duplicate code detected - 7 lines duplicated with src/main/java/timewaster/publicteleport/Storage.java:356

github-actions · 2026-09-15T13:33:42Z

-            return false;
-        }
+    public static boolean teleportPlayer(ServerPlayer player, Teleport teleportTarget) {
        ServerLevel level = TeleportSafety.getLevelFromDimension(player, teleportTarget.dimension());


⚠️ Duplicate code detected - 15 lines duplicated with src/main/java/timewaster/publicteleport/Teleports.java:186

github-actions · 2026-09-15T13:33:43Z

+     * @param newPortal the {@link Portal} to add or update
+     * @return {@code true} if successful, {@code false} on file error
+     */
+    public boolean setPortal(ServerPlayer player, Portal newPortal) {


⚠️ Duplicate code detected - 5 lines duplicated with src/main/java/timewaster/publicteleport/Storage.java:418

github-actions · 2026-09-15T13:33:44Z

-        dispatcher.register(Commands.literal("setwarp").requires(PERMISSIONS_OWNER)
-            .then(Registrar.buildArgumentString("name", typeNone, (ServerPlayer player, String argValue) -> {
+        dispatcher.register(Commands.literal("setwarp").requires(Commands.hasPermission(Commands.LEVEL_OWNERS))
+            .then(Registrar.buildArgumentString("name", NONE, (ServerPlayer player, String argValue) -> {


⚠️ Duplicate code detected - 4 lines duplicated with src/main/java/timewaster/publicteleport/commands/Warps.java:81

github-actions · 2026-09-15T13:33:45Z

                if (argValue.equals("back")) {
-                    Messages.sendMessage(player, "home_reserved_name", Messages.MessageType.WARNING);
+                    Messages.sendMessage(player, "home_reserved_name", WARNING);
                    return false;


⚠️ Duplicate code detected - 7 lines duplicated with src/main/java/timewaster/publicteleport/commands/Warps.java:37

github-actions · 2026-09-15T13:33:45Z

@@ -157,7 +197,7 @@ public static RequiredArgumentBuilder<CommandSourceStack, String> buildArgumentS
        SuggestionType suggestionType, BiFunction<ServerPlayer, String, Boolean> callback) {
        return Commands.argument(argName, Objects.requireNonNull(StringArgumentType.word()))


⚠️ Duplicate code detected - 4 lines duplicated with src/main/java/timewaster/publicteleport/Registrar.java:224

github-actions · 2026-09-15T13:33:46Z


                if (!TeleportSafety.isBlockTeleportable(player, target)) {
-                    Messages.sendMessage(player, "teleport_unsafe_set", Messages.MessageType.ERROR, "Spawn");
+                    Messages.sendMessage(player, "teleport_unsafe_set", ERROR, "Spawn");


⚠️ Duplicate code detected - 11 lines duplicated with src/main/java/timewaster/publicteleport/commands/Warps.java:43

github-actions · 2026-09-15T13:33:47Z

            }
+
+            if (type == SuggestionType.PORTALS) {
+                List<Portal> portals = PublicTeleport.storage.getPortals();


⚠️ Duplicate code detected - 6 lines duplicated with src/main/java/timewaster/publicteleport/commands/Portals.java:263

github-actions · 2026-09-16T13:36:22Z

@@ -296,7 +323,7 @@ public Boolean setTeleport(ServerPlayer player, Teleport newTeleport, boolean is
        int numTeleports = 0;

        if (teleports == null) {


⚠️ Duplicate code detected - 7 lines duplicated with src/main/java/timewaster/publicteleport/Storage.java:373

github-actions · 2026-09-16T13:36:23Z

-            return false;
-        }
+    public static boolean teleportPlayer(ServerPlayer player, Teleport teleportTarget) {
        ServerLevel level = TeleportSafety.getLevelFromDimension(player, teleportTarget.dimension());


⚠️ Duplicate code detected - 15 lines duplicated with src/main/java/timewaster/publicteleport/Teleports.java:189

github-actions · 2026-09-16T13:36:23Z

+     * @param newPortal the {@link Portal} to add or update
+     * @return {@code true} if successful, {@code false} on file error
+     */
+    public boolean setPortal(ServerPlayer player, Portal newPortal) {


⚠️ Duplicate code detected - 5 lines duplicated with src/main/java/timewaster/publicteleport/Storage.java:435

github-actions · 2026-09-16T13:36:24Z

-            .then(Registrar.buildArgumentString("name", typeNone, (ServerPlayer player, String argValue) -> {
-                if (argValue.equals("spawn")) {
+        dispatcher.register(Commands.literal("setwarp").requires(Commands.hasPermission(Commands.LEVEL_OWNERS))
+            .then(Registrar.buildArgumentString("name", NONE, (ServerPlayer player, String argValue) -> {


⚠️ Duplicate code detected - 4 lines duplicated with src/main/java/timewaster/publicteleport/commands/Warps.java:84

github-actions · 2026-09-16T13:36:25Z

@@ -157,7 +200,7 @@ public static RequiredArgumentBuilder<CommandSourceStack, String> buildArgumentS
        SuggestionType suggestionType, BiFunction<ServerPlayer, String, Boolean> callback) {
        return Commands.argument(argName, Objects.requireNonNull(StringArgumentType.word()))


⚠️ Duplicate code detected - 4 lines duplicated with src/main/java/timewaster/publicteleport/Registrar.java:227

github-actions · 2026-09-16T13:36:26Z


                if (!TeleportSafety.isBlockTeleportable(player, target)) {
-                    Messages.sendMessage(player, "teleport_unsafe_set", Messages.MessageType.ERROR, "Spawn");
+                    Messages.sendMessage(player, "teleport_unsafe_set", ERROR, "Spawn");


⚠️ Duplicate code detected - 11 lines duplicated with src/main/java/timewaster/publicteleport/commands/Warps.java:46

github-actions · 2026-09-16T13:36:26Z

            }
+
+            if (type == SuggestionType.PORTALS) {
+                List<Portal> portals = PublicTeleport.storage.getPortals();


⚠️ Duplicate code detected - 6 lines duplicated with src/main/java/timewaster/publicteleport/commands/Portals.java:266

github-actions · 2026-09-16T13:36:27Z

                return Teleports.teleportPlayer(player, "home", false);
            })));

        dispatcher.register(Commands.literal("homes")


⚠️ Duplicate code detected - 3 lines duplicated with src/main/java/timewaster/publicteleport/commands/Warps.java:97

github-actions · 2026-09-16T13:36:28Z

@@ -110,14 +126,18 @@ private Map<String, String> loadTranslations() {
        try {
            modContainer = fabricLoader.getModContainer(PublicTeleport.MOD_ID).get();


⚠️ Duplicate code detected - 4 lines duplicated with src/main/java/timewaster/publicteleport/Storage.java:136

github-actions · 2026-09-16T15:06:32Z

@@ -192,26 +202,22 @@ public static boolean cancelRequest(ServerPlayer sender) {
     * @return {@code true} if a matching request was found and executed
     */
    public static boolean acceptRequest(@Nullable ServerPlayer sender, ServerPlayer receiver) {


⚠️ Duplicate code detected - 9 lines duplicated with src/main/java/timewaster/publicteleport/Requests.java:242

github-actions · 2026-09-16T15:06:33Z

-            .then(Registrar.buildArgumentString("name", typeNone, (ServerPlayer player, String argValue) -> {
-                if (argValue.equals("spawn")) {
+        dispatcher.register(Commands.literal("setwarp").requires(Commands.hasPermission(Commands.LEVEL_OWNERS))
+            .then(Registrar.buildArgumentString("name", NONE, (ServerPlayer player, String argValue) -> {


⚠️ Duplicate code detected - 4 lines duplicated with src/main/java/timewaster/publicteleport/commands/Warps.java:78

github-actions · 2026-09-16T16:18:00Z

@@ -192,26 +204,22 @@ public static boolean cancelRequest(ServerPlayer sender) {
     * @return {@code true} if a matching request was found and executed
     */
    public static boolean acceptRequest(@Nullable ServerPlayer sender, ServerPlayer receiver) {


⚠️ Duplicate code detected - 9 lines duplicated with src/main/java/timewaster/publicteleport/Requests.java:244

github-actions · 2026-09-16T16:18:01Z

+     * @param newPortal the {@link Portal} to add or update
+     * @return {@code true} if successful, {@code false} on file error
+     */
+    public boolean setPortal(ServerPlayer player, Portal newPortal) {


⚠️ Duplicate code detected - 5 lines duplicated with src/main/java/timewaster/publicteleport/Storage.java:439

github-actions · 2026-09-16T16:18:02Z

@@ -157,8 +196,8 @@ public static RequiredArgumentBuilder<CommandSourceStack, String> buildArgumentS
        SuggestionType suggestionType, BiFunction<ServerPlayer, String, Boolean> callback) {
        return Commands.argument(argName, Objects.requireNonNull(StringArgumentType.word()))


⚠️ Duplicate code detected - 4 lines duplicated with src/main/java/timewaster/publicteleport/Registrar.java:223

github-actions · 2026-09-16T16:18:03Z

@@ -296,32 +325,34 @@ public Boolean setTeleport(ServerPlayer player, Teleport newTeleport, boolean is
        int numTeleports = 0;

        if (teleports == null) {


⚠️ Duplicate code detected - 6 lines duplicated with src/main/java/timewaster/publicteleport/Storage.java:377

Time Waster added 9 commits August 28, 2026 14:50

Better separation of commands

07f79df

The command '/spawn' now uses the world spawn as fallback if the targ…

f87bae6

…et was not set by '/setspawn'

The command '/spawn' now uses the world spawn as fallback if the targ…

e8a083a

…et was not set by '/setspawn'

The command '/spawn' now uses the world spawn as fallback if the targ…

2424004

…et was not set by '/setspawn'

added Portal functionality

2ad7628

added url checking, text fixes/additions

59abf2b

code cleanup and documentation

79b0c32

bump version number

3da15f3

testing github actions

fc6efe1

SebiTimeWaster self-assigned this Sep 15, 2026

SebiTimeWaster added the enhancement New feature or request label Sep 15, 2026

Time Waster added 4 commits September 15, 2026 13:00

testing github actions

ed9f6f6

testing github actions

f1d1d52

testing github actions

6183c5f

testing github actions

e5b2f62

testing github actions

07b5f88

github-actions Bot reviewed Sep 15, 2026

View reviewed changes

incorporateed PMD results

c38021e

github-actions Bot reviewed Sep 16, 2026

View reviewed changes

incorporated CPD results

19dfbba

github-actions Bot reviewed Sep 16, 2026

View reviewed changes

abstracted reused code snippets

3b5fe12

github-actions Bot reviewed Sep 16, 2026

View reviewed changes

Time Waster added 3 commits September 16, 2026 16:35

added build tasks on pull requests

7b04892

added release task to auto create release files

52761ab

added release task to auto create release files

c71e8d2

SebiTimeWaster force-pushed the upcoming branch 2 times, most recently from 8732491 to c71e8d2 Compare September 19, 2026 18:40

Time Waster added 2 commits September 19, 2026 18:40

Merge branch 'main' into upcoming

6302e14

added PMD check

6ba0d4a

		@@ -296,7 +306,7 @@ public Boolean setTeleport(ServerPlayer player, Teleport newTeleport, boolean is
		int numTeleports = 0;

		if (teleports == null) {

		@@ -157,7 +197,7 @@ public static RequiredArgumentBuilder<CommandSourceStack, String> buildArgumentS
		SuggestionType suggestionType, BiFunction<ServerPlayer, String, Boolean> callback) {
		return Commands.argument(argName, Objects.requireNonNull(StringArgumentType.word()))

		@@ -296,7 +323,7 @@ public Boolean setTeleport(ServerPlayer player, Teleport newTeleport, boolean is
		int numTeleports = 0;

		if (teleports == null) {

		@@ -157,7 +200,7 @@ public static RequiredArgumentBuilder<CommandSourceStack, String> buildArgumentS
		SuggestionType suggestionType, BiFunction<ServerPlayer, String, Boolean> callback) {
		return Commands.argument(argName, Objects.requireNonNull(StringArgumentType.word()))

		@@ -110,14 +126,18 @@ private Map<String, String> loadTranslations() {
		try {
		modContainer = fabricLoader.getModContainer(PublicTeleport.MOD_ID).get();

		@@ -157,8 +196,8 @@ public static RequiredArgumentBuilder<CommandSourceStack, String> buildArgumentS
		SuggestionType suggestionType, BiFunction<ServerPlayer, String, Boolean> callback) {
		return Commands.argument(argName, Objects.requireNonNull(StringArgumentType.word()))

		@@ -296,32 +325,34 @@ public Boolean setTeleport(ServerPlayer player, Teleport newTeleport, boolean is
		int numTeleports = 0;

		if (teleports == null) {

Conversation

SebiTimeWaster commented Sep 15, 2026

Uh oh!

github-actions Bot commented Sep 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Duplicate Code Report

✅ PMD CPD

✅ jscpd (language-agnostic)

Uh oh!

github-actions Bot Sep 15, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Sep 15, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Sep 15, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Sep 15, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Sep 15, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Sep 15, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Sep 15, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Sep 15, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Sep 15, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Sep 16, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Sep 16, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Sep 16, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Sep 16, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Sep 16, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Sep 16, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Sep 16, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Sep 16, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Sep 16, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Sep 16, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Sep 16, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Sep 16, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Sep 16, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Sep 16, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Sep 16, 2026

Choose a reason for hiding this comment

github-actions Bot commented Sep 15, 2026 •

edited

Loading