Downhole collection intervals - #325
Open
sergiopeixoto-seequent wants to merge 32 commits into
Open
Conversation
…able loading functions - removal of depreaction warnings
…n tests for interval collections
l-macdonald
approved these changes
Aug 5, 2026
# Conflicts: # packages/evo-objects/src/evo/objects/typed/downhole_collection.py # packages/evo-objects/tests/typed/test_downhole_collection.py
sergiopeixoto-seequent
changed the title
daniel-kinney-seequent
requested changes
Aug 10, 2026
… and IntervalCollection
…te convention, but treat persisted hole_index values as keys from the hole_id lookup table when reading existing objects.
… desurvey settings.
…for keywords arguments
…emove redundant method
…havior and improve hole data handling
…_index is the integer key in the object's hole_id lookup table, not a positional categorical code. DownholeCollectionData and DownholeCollection no longer assume it is zero-based or contiguous.
…nd attribute handling
| """Run-length encode contiguous hole IDs into ``[hole_index, offset, count]`` chunks. | ||
|
|
||
| ``hole_indices`` maps hole IDs to their lookup-table keys. When omitted, this | ||
| creation helper assigns dense zero-based keys in sorted ID order. Persisted |
Contributor
There was a problem hiding this comment.
I think this comment is out of date now.
…fy key assignment behavior
| for hole_index, offset, count in self.holes[["hole_index", "offset", "count"]].itertuples( | ||
| index=False, name=None | ||
| ): | ||
| coordinates = collars_by_index.loc[int(hole_index), _COORDINATE_COLUMNS].to_numpy(dtype=np.float64) |
Contributor
There was a problem hiding this comment.
This mapping from hole_index to properties (which is called "collars" in this function) doesn't look like what I was expecting. I thought hole_index was a straight lookup into properties.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implemented typed interval and indexed DownholeCollection support in evo-objects, including polymorphic collection handling, hole-index validation, DataFrame read APIs, prefetching, attribute-description round-tripping, and static-context creation. The branch also bumps evo-objects to 0.6.2
Checklist