Skip to content

fix(core): recognize packager- and publisher- plugin category prefixes #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mwaldheim wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(core): recognize packager- and publisher- plugin category prefixes #239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/cli/doctor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,7 +431,7 @@ func checkRecommendations(cfg *config.Config) []DoctorCheck {
// so that suggestions are suppressed regardless of whether the user's config
// uses the short or prefixed plugin name.
configured := map[string]bool{}
categoryPrefixes := []string{"provider-", "condition-", "analyzer-", "generator-", "updater-", "hook-"}
categoryPrefixes := []string{"provider-", "condition-", "analyzer-", "generator-", "updater-", "hook-", "packager-", "publisher-"}
registerName := func(raw string) {
name := strings.ToLower(strings.TrimSpace(raw))
if name == "" {
Expand Down
2 changes: 1 addition & 1 deletion internal/cli/root.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1151,7 +1151,7 @@ func legacyPluginBinaryName(uses string) string {
uses = uses[:idx]
}
lower := strings.ToLower(uses)
for _, prefix := range []string{"provider-", "condition-", "analyzer-", "generator-", "updater-", "hook-"} {
for _, prefix := range []string{"provider-", "condition-", "analyzer-", "generator-", "updater-", "hook-", "packager-", "publisher-"} {
if strings.HasPrefix(lower, prefix) {
uses = uses[len(prefix):]
break
Expand Down
2 changes: 1 addition & 1 deletion internal/registry/metadata.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ type Compatibility struct {
// ("github-actions", "github", "go"), so FindPlugin strips these prefixes as a
// fallback when no exact match is found.
var categoryPrefixes = []string{
"provider-", "condition-", "analyzer-", "generator-", "updater-", "hook-",
"provider-", "condition-", "analyzer-", "generator-", "updater-", "hook-", "packager-", "publisher-",
}

// FindPlugin returns the registry entry for the named plugin.
Expand Down
Loading