feat(scol): validate oauth2 token_url scheme at vector validate time#100
Closed
JuanMantica45 wants to merge 3 commits into
Closed
feat(scol): validate oauth2 token_url scheme at vector validate time#100JuanMantica45 wants to merge 3 commits into
JuanMantica45 wants to merge 3 commits into
Conversation
Call Config::validate_auth() synchronously in SourceConfig::build() before boxing the source future, so vector validate catches invalid token_url values at the Component configuration step rather than silently deferring to runtime. Bump lib/observo/private to ef53ab5 which adds SAuth::validate() and Config::validate_auth() in the dataplane-private submodule.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps the `lib/observo/private` submodule to pick up oauth2 `token_url` scheme validation (dataplane-private PR #42).
No code changes to vector itself — validation happens entirely within the `dataplane-private` crate at config parse time via `#[serde(deserialize_with)]` on the `token_url` field. An invalid URL now causes `vector validate` to fail at the `√ Loaded` step with a clear error message.
Dependency
dataplane-private PR #42 (merged): https://ghe.eng.sentinelone.tech/sentinel-one/dataplane-private/pull/42
What changes