Potential fix for code scanning alert no. 48: Uncontrolled command line#106
Merged
Conversation
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/Servoy/servoy-eclipse/security/code-scanning/48
General fix approach: keep using
ProcessBuilderwith separated arguments, but enforce strict allowlisting of what executable/application path can be launched, and ensure untrusted values can only select among expected literals/paths.Best single fix (without changing functionality): in
StartNGDesktopClientHandler.java, before callingbuilder.command(...), add a strict validation that the resolved executable/app path filename is exactly the expected NG Desktop binary/app name for the current OS (servoyngdesktoporservoyngdesktop.app) and reject anything else. Then keep current execution logic. This complements existing path-boundary checks and addresses CodeQL’s taint concern by proving the launched target is fixed/allowlisted, not arbitrary user-controlled.Needed changes:
com.servoy.eclipse.debug/src/com/servoy/eclipse/debug/handlers/StartNGDesktopClientHandler.javaSuggested fixes powered by Copilot Autofix. Review carefully before merging.