Add on-device English lyric translation - #3
Open
KashishSingh0936 wants to merge 1 commit into
Open
Conversation
Rtx09x
marked this pull request as ready for review
August 3, 2026 05:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Shippy already displays synchronized and plain lyrics, but listeners cannot understand non-English lyrics inside the app. This adds a narrow, user-initiated translation utility without introducing cloud credentials, automatic translation, or broader AI branding.
User impact
Listeners can request an English translation while keeping the original lyrics visible. The UI discloses the approximately 30 MB on-device model download, attributes the translation to Google, and reports loading, already-English, unsupported-language, and retryable failure states without hiding the original lyrics.
Validation
Shippy-Music/Shippy:mainat7fb431c9fgit diff --checkpasseddialog_lyrics.xmlparsed successfully