Skip to content

[Web] Use a button for checkout overlay focus - #688

Merged
markmur merged 5 commits into
mainfrom
fix/web-overlay-standalone-fallback
Aug 25, 2026
Merged

[Web] Use a button for checkout overlay focus#688
markmur merged 5 commits into
mainfrom
fix/web-overlay-standalone-fallback

Conversation

@markmur

@markmur markmur commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

What changes are you making?

  • Replace the overlay anchor with a native button because its action is to focus the already-open checkout window, not navigate.
  • Remove the overlay URL and href update logic, preventing browser-managed tabs from loading an embedded checkout without a transport.
  • Preserve the link-like visual treatment while providing native button keyboard semantics.
  • Define CHECKOUT_KIT_PACKAGE_VERSION in the sample Vite build so direct source imports run correctly.

Fixes https://github.com/shop/issues/issues/74036
Related to https://github.com/shop/issues/issues/77405

@github-actions github-actions Bot added the #gsd:50662 Rebase Checkout Kit on UCP label Aug 24, 2026
@markmur markmur self-assigned this Aug 24, 2026
@markmur markmur changed the title [Web] Handle browser-managed overlay navigation [Web] Use a button for checkout overlay focus Aug 24, 2026
@markmur
markmur marked this pull request as ready for review August 25, 2026 08:38
@markmur
markmur requested a review from a team as a code owner August 25, 2026 08:38
@github-actions

Copy link
Copy Markdown

Web — Coverage Report

Lines Statements Branches Functions
Coverage: 96%
94.4% (287/304) 81.11% (146/180) 98.7% (76/77)

@github-actions

Copy link
Copy Markdown

Package Size

Platform Artifact Base Head Delta
Web npm tarball 70.6 KiB 70.2 KiB -350 B
Web file breakdown
File Base Head Delta
dist/index.js.map 192.2 KiB 191.6 KiB -594 B
dist/index.d.ts 44.9 KiB 44.9 KiB 0 B
dist/custom-elements.json 44.0 KiB 43.8 KiB -279 B
dist/index.js 31.5 KiB 31.5 KiB -31 B
README.md 19.0 KiB 19.0 KiB 0 B
package.json 2.8 KiB 2.8 KiB 0 B
LICENSE 1.1 KiB 1.1 KiB 0 B

Measured from the PR base SHA and PR head SHA. The file breakdown shows uncompressed sizes within each package artifact, so individual files do not sum to the compressed artifact total. This comment reports package artifact sizes only; it is not a final app binary-size report.

@markmur
markmur merged commit 0dae8ee into main Aug 25, 2026
47 checks passed
@markmur
markmur deleted the fix/web-overlay-standalone-fallback branch August 25, 2026 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

#gsd:50662 Rebase Checkout Kit on UCP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants