Skip to content

libfetchers: drop leading slash from the git-lfs credential path #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lilyinstarlight merged 1 commit into from
Aug 10, 2026
Merged

libfetchers: drop leading slash from the git-lfs credential path #46

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/libfetchers/git-lfs-fetch.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,10 +101,15 @@ static LfsApiInfo getLfsApi(const ParsedURL & url)

return {href, authIt->get<std::string>()};
} else {
// git credential attributes take the path decoded and without a leading slash
auto credentialPath = url.renderPath(false);
if (credentialPath.starts_with("/"))
credentialPath.erase(0, 1);

std::ostringstream inputCredDescr;
inputCredDescr << "protocol=" << url.scheme << "\n";
inputCredDescr << "host=" << url.authority->host << "\n";
inputCredDescr << "path=" << url.renderPath(true) << "\n";
inputCredDescr << "path=" << credentialPath << "\n";

auto [status, output] =
runProgram({.program = "git", .args = {"credential", "fill"}, .input = std::move(inputCredDescr).str()});
Expand All @@ -114,7 +119,7 @@ static LfsApiInfo getLfsApi(const ParsedURL & url)
"git-credential-fill: no output (cmd: 'git credential fill' for protocol=%s, host=%s, path=%s)",
url.scheme,
url.authority->host,
url.renderPath(true));
credentialPath);

std::string username;
std::string password;
Expand All @@ -135,7 +140,7 @@ static LfsApiInfo getLfsApi(const ParsedURL & url)
"git-credential-fill: no credentials returned (cmd: 'git credential fill' for protocol=%s, host=%s, path=%s)",
url.scheme,
url.authority->host,
url.renderPath(true));
credentialPath);

return {
url.to_string(),
Expand Down
Loading