tecnix: intern builtin argument names at call time, not statically - #49
Merged
Conversation
Adding gitDir, resolver, rev, checkoutPath, and targets to StaticEvalSymbols assigned them the lowest symbol ids, ahead of every symbol interned while evaluating user code. Bindings iterate in symbol-id order, so pre-interning common attr names like 'targets' and 'rev' observably reordered attribute iteration for every attrset containing them -- for example, which error a deepSeq (or nix-unit's forceValueDeep) surfaces first out of an attrset with several throwing attributes. These lookups run once per tecnixTargets/tecnixTargetNames call, right before git subprocesses, SQLite reads, and target evaluation, so the static ids bought nothing measurable. Intern the names at call time instead, like upstream's fetcher builtins do, which restores upstream-identical iteration order.
Contributor
Author
|
trivial fix just gonna merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding gitDir, resolver, rev, checkoutPath, and targets to StaticEvalSymbols assigned them the lowest symbol ids, ahead of every symbol interned while evaluating user code. Bindings iterate in symbol-id order, so pre-interning common attr names like 'targets' and 'rev' observably reordered attribute iteration for every attrset containing them -- for example, which error a deepSeq (or nix-unit's forceValueDeep) surfaces first out of an attrset with several throwing attributes.
These lookups run once per tecnixTargets/tecnixTargetNames call, right before git subprocesses, SQLite reads, and target evaluation, so the static ids bought nothing measurable. Intern the names at call time instead, like upstream's fetcher builtins do, which restores upstream-identical iteration order.