Feature/dynamic scenario#59
Draft
heavenfall wants to merge 75 commits into
Draft
Conversation
heavenfall
commented
May 8, 2026
| "values in scen file) \n" | ||
| << "\t--costs [costs file] (required if using a weighted " | ||
| "terrain algorithm)\n" | ||
| << "\t--v2-cost [type] (optional; change used cost type for v2 scen " |
Collaborator
Author
There was a problem hiding this comment.
change to --cost and --cost-file, if read from file override instances by values in file
dharabor
requested changes
May 8, 2026
Member
dharabor
left a comment
dharabor
left a comment
There was a problem hiding this comment.
Looks good. some small changes mainly.
| Search& algo, std::string alg_name, | ||
| warthog::util::scenario_manager& scenmgr, bool verbose, bool checkopt, | ||
| std::ostream& out) | ||
| Search& algo, std::string alg_name, gridmap_scenario& scen, bool verbose, |
Member
There was a problem hiding this comment.
Do all possible instatiations of algo work with all possible gridmap_scenario instantiations?
| if(expander == nullptr) return 1; | ||
|
|
||
| out << "id\talg\texpanded\tgenerated\treopen\tsurplus\theapops" | ||
| out << "id\tsnapshot\talg\texpanded\tgenerated\treopen\tsurplus\theapops" |
Member
There was a problem hiding this comment.
We should update the README with new column names + new command-line options. Also update examples.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge dynamic scenario support.