feat: add deterministic session review projection core - #260
Open
harshitethic wants to merge 3 commits into
Open
harshitethic wants to merge 3 commits into
harshitethic wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a dependency-free review projection layer for #242 so the local review UI can consume one deterministic representation of ordered evidence instead of re-implementing relationship and filter logic in the frontend.
What it provides
none,linked, ororphanedgapswithout inventing synthetic relationshipsTrust boundary
The projector intentionally classifies only recorded facts. Semantic categories such as tests, commands, retries, and recovery require explicit event metadata; it does not guess them from command text or natural-language output. A clean projection therefore is not a claim of complete provider capture.
Tests
tests/test_review.pycovers ordering, linked tool results, orphaned results, category filters, retry/recovery metadata, redaction/privacy visibility, and stable timestamp ties.Documentation
docs/session-review-projection.mddocuments ordering, relationship semantics, filter rules, raw evidence preservation, and the no-inference boundary.Scope
This is a focused core for #242, not a claim to close the UI issue. It does not yet replace the dashboard, render annotations, calculate evidence health, or add keyboard/URL navigation. Those layers can build on this projection without duplicating evidence semantics.
Validation
The implementation and tests are stdlib-only beyond AgentTrace's existing
TraceEventmodel. The connected development machine is currently offline, so I have not claimed local execution; upstream CI is the verification gate for this branch.Refs #242.