feat(vocab): add evidence-gated tokens from imas-codex rotation waves 7 and 9 - #11
Open
Simon-McIntosh wants to merge 1 commit into
Open
feat(vocab): add evidence-gated tokens from imas-codex rotation waves 7 and 9#11Simon-McIntosh wants to merge 1 commit into
Simon-McIntosh wants to merge 1 commit into
Conversation
… 7 and 9 Add 5 tokens from W7+W9A that passed the N>=3 evidence gate (33 VocabGap candidates harvested across gyrokinetics, plasma_wall_interactions, and particle_measurement_diagnostics domains). Additions: - physical_bases.yml: x2_width (N=43) — symmetric counterpart to x1_width - subjects.yml: gyroaveraged (N=15) — gyrokinetics gyroaveraged moments - locus_registry.yml: vessel_outline_point (N=6), focs_outline_point (N=3), limiter_outline_point (N=3) Rejected: from_wall, from_plasma (preposition-form ban in compose grammar) Deferred: 20 tokens at N<3 documented in docs/vocab-retrospective.md Pre-existing in ISN: outboard_midplane, inner/outer_divertor_target, divertor_target, constraint_position, current_center, last_closed_flux_surface Grammar model_types.py regenerated via build-grammar.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add 5 vocabulary tokens from imas-codex rotation waves W7 and W9A that cleared the N≥3 evidence gate. 33 VocabGap tokens were accumulated; 7 were already present in ISN; 2 were explicitly rejected; 5 qualify.
Source: imas-codex rotation waves 7 and 9A (synthesis in
research/wave9-synthesis.md, commits7cadf043and317ea706in imas-codex).Evidence for new vocabulary tokens
Tokens proposed
x2_widthphysical_bases.ymlbolometer/camera/channel/aperture/x2_width,bolometer/channel/detector/x2_width,camera_ir/fibre_bundle/geometry/x2_width,camera_visible/channel/aperture/x2_width,camera_x_rays/aperture/x2_widthgyroaveragedsubjects.ymlgyrokinetics/…/moments_norm_gyrocenter/density_gyroav,/heat_flux_parallel_gyroav,/j_parallel_gyroav,/pressure_parallel_gyroav,/pressure_perpendicular_gyroavvessel_outline_pointlocus_registry.ymlwall/description_2d/vessel/unit/annular/outline_inner/r,/outline_inner/z,/outline_outer/r,/outline_outer/z,/element/outline/r,/element/outline/zfocs_outline_pointlocus_registry.ymlfocs/outline/r,focs/outline/z,focs/outline/philimiter_outline_pointlocus_registry.ymlwall/description_2d/limiter/unit/outline,/outline/r,/outline/zEvidence gathered via
imas-codexgraph query onIMASNodepaths. Thex2_widthtoken is the symmetric counterpart ofx1_widthadded at rc27.Why existing tokens do not suffice
x2_width: The 43 DD paths use the literal field namex2_width— no existing base token covers the aperture/detector X2 dimension width. Parallelsx1_width(added rc27).gyroaveraged: The 15density_gyroav,heat_flux_parallel_gyroavetc. paths ingyrokineticsIDS all represent gyroaveraged moments; no existing subject token covers this population qualifier.vessel_outline_point,focs_outline_point,limiter_outline_point: Follow the established<entity>_outline_pointpattern (cf.control_surface_outline_point,secondary_separatrix_outline_pointalready in ISN). Each names a specific geometric sampling location on a machine component.Tokens pre-existing in ISN (no action taken)
These tokens appeared in imas-codex VocabGap accumulation but are already
present in
locus_registry.yml:outboard_midplane,inner_divertor_target,outer_divertor_target,divertor_target,constraint_position,current_center,last_closed_flux_surfaceTokens explicitly rejected
from_wall_from_/_to_ban incompose_system_lean.md)from_plasmaTokens deferred (N<3)
diagnostic_component_centerdetector_aperturediagnostic_apertureentity may cover; possibly redundantmobile_unit_outline_pointshearing_rateshearing_rate_normpaths in gyrokinetics — just misses gatespun_fiberannularvertical_coordinate_ofcartesian_xMotivation
imas-codex rotation waves W7 and W9A accumulated 33 unique VocabGap tokens that
blocked standard-name composition across gyrokinetics, plasma-wall interactions,
and particle-measurement diagnostics domains. This batch closes the 5 tokens
with sufficient DD evidence.
Changes
imas_standard_names/grammar/vocabularies/physical_bases.yml— addx2_widthimas_standard_names/grammar/vocabularies/subjects.yml— addgyroaveragedimas_standard_names/grammar/vocabularies/locus_registry.yml— addvessel_outline_point,focs_outline_point,limiter_outline_pointimas_standard_names/grammar/model_types.py— regenerateddocs/vocab-retrospective.md— W7+W9A triage section appendedTesting
1108 passed, 68 xfailed)Checklist