Image extract chrome#9
Open
Karaviro wants to merge 10 commits into
Open
Conversation
Owner
|
Hi, it's nice to see you've found the addon useful. I'm a little confused why this is opened as a PR that would overwrite the Firefox addon with the Chromium port? I'd definitely be interested in porting the new functionality you've written to retrieve additional images and UI enhancements though! When I tried having a separate browser tab for the viewer I got bug reports that the addon wasn't working properly, and eventually confirmed that some websites like Instagram have configured CORS such that their images will not load for a different origin such as a browser extension tab. I'm curious if you've seen these problems as well, since I'd expect you would have the same problem and I can see some code in there that refers to cors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a Chrome/Edge port