runtime: drop debug stdout print when SKIP_CAPACITY is set#1252
Merged
Conversation
sk_create_mapping printed "CAPACITY SET TO: <bytes>" to stdout for every Skip process started with a non-default capacity. This was debug output that escaped into normal stdout — fine when nothing relied on stdout exactness, but the skdb diff tests (test/diff/*.sql) compare runtime stdout to .expected golden files and now fail on every test once SKIP_CAPACITY is set in CI (e.g. via the gen2 fix in #1246). Just remove the print. The value is observable via /proc/self/maps or by recognising the cgroup limit; no observability is being lost that needed to be on stdout. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
mbouaziz
force-pushed
the
runtime-drop-capacity-print
branch
from
b36349a to
a9c4e2d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sk_create_mappingin skiplang/prelude/runtime/palloc.c:567-569 printedCAPACITY SET TO: <bytes>to stdout for every Skip process started with a non-default capacity.This was harmless until #1246 set
SKIP_CAPACITYon gen2 CI jobs to avoidMAP FAILEDOOMs. Now every Skip process emits the line, and the skdb diff tests (test/diff/*.sql) — which compare runtime stdout to.expectedgolden files — fail on every test.Observed in job 16738 (skdb on
large.gen2,SKIP_CAPACITY=6G→6442450944):Repeated for ~40 diff tests. The skdb workflow has been silently broken for any PR that triggers it (most don't, because of generate_config.sh's per-package diff heuristic; this PR triggered it because it touches a
skiplang/prelude/file).Fix
Remove the print. If anyone needs to confirm the runtime's capacity at startup,
/proc/self/mapsor the--capacityCLI flag echo are cleaner channels — stdout is reserved for program output that golden-file tests can rely on.Test plan
skiplang/prelude/and triggersskdbshould now pass.compilerandskipruntime(also affected, since they run withSKIP_CAPACITY=12G/6G) should remain green — they don't compare stdout, so they weren't failing visibly, but the line was still being emitted and cluttering logs.🤖 Generated with Claude Code