Skip to content

amend: Fix last-touched functionality - #267

Merged
jerry-skydio merged 1 commit into
mainfrom
jerry/revup/main/fixlasttouched
Jul 27, 2026
Merged

amend: Fix last-touched functionality#267
jerry-skydio merged 1 commit into
mainfrom
jerry/revup/main/fixlasttouched

Conversation

@jerry-skydio

Copy link
Copy Markdown
Collaborator

last-touched will amend the file into the correct
commit, but incorrectly then removes the changes immediately
when replaying the rest of the stack on top. This was not
caught by tests because those only checked the exact commit
and file, without checking that the rest of the stack is
correct.

Fix this by reimplementing with the merge-tree engine, which
is more modern and faster anyway. Update tests to catch this case.

@jerry-skydio

jerry-skydio commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator Author

Reviews in this chain:
#267 amend: Fix last-touched functionality
 └#276 amend: Fix last-touched when deleting files
  └#284 git: Use -z for null separated parsing

@jerry-skydio

jerry-skydio commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator Author
# head base diff date summary
0 8c729e81 189dacb5 diff Jun 25 13:06 PM 3 files changed, 75 insertions(+), 24 deletions(-)
1 9279b2fe 29c140d2 diff Jun 25 13:35 PM 0 files changed
2 6f491aac d8008423 rebase Jun 26 10:38 AM 0 files changed
3 72e5eae6 d8008423 diff Jul 23 14:41 PM 1 file changed, 29 insertions(+), 12 deletions(-)
4 0f68ad0f d8008423 diff Jul 23 14:59 PM 2 files changed, 29 insertions(+), 30 deletions(-)
5 d9e4421c d8008423 diff Jul 23 16:01 PM 1 file changed, 7 insertions(+), 1 deletion(-)
6 f3120035 bb92346f rebase Jul 27 13:47 PM 0 files changed
7 d6fce997 6b948064 rebase Jul 27 13:52 PM 0 files changed

Base automatically changed from jerry/revup/main/amendcommit to main June 25, 2026 20:34
@jerry-skydio
jerry-skydio force-pushed the jerry/revup/main/fixlasttouched branch 2 times, most recently from 9279b2f to 6f491aa Compare June 26, 2026 17:38
@jerry-skydio
jerry-skydio force-pushed the jerry/revup/main/fixlasttouched branch 2 times, most recently from 72e5eae to 0f68ad0 Compare July 23, 2026 21:59
@jerry-skydio
jerry-skydio force-pushed the jerry/revup/main/fixlasttouched branch from 0f68ad0 to d9e4421 Compare July 23, 2026 23:01
@jerry-skydio
jerry-skydio force-pushed the jerry/revup/main/fixlasttouched branch from d9e4421 to f312003 Compare July 27, 2026 20:47
last-touched will amend the file into the correct
commit, but incorrectly then removes the changes immediately
when replaying the rest of the stack on top. This was not
caught by tests because those only checked the exact commit
and file, without checking that the rest of the stack is
correct.

Fix this by reimplementing with the merge-tree engine, which
is more modern and faster anyway. Update tests to catch this case.
@jerry-skydio
jerry-skydio force-pushed the jerry/revup/main/fixlasttouched branch from f312003 to d6fce99 Compare July 27, 2026 20:52
@jerry-skydio
jerry-skydio merged commit fa6fd31 into main Jul 27, 2026
6 checks passed
@jerry-skydio
jerry-skydio deleted the jerry/revup/main/fixlasttouched branch July 27, 2026 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants