Skip to content

Commented out coreaudio warning regarding buffer underflow #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
heavyrubberslave merged 3 commits into from
Jan 11, 2026
Merged

Commented out coreaudio warning regarding buffer underflow #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8a6ddb5
Commented out coreaudio warning regarding buffer underflow
heavyrubberslave Jan 11, 2026
8a20f2d
Add test summary to use as status check
heavyrubberslave Jan 11, 2026
26f0751
Don't run tests on every push
heavyrubberslave Jan 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: Node CI

on: [push, pull_request]
on: pull_request

jobs:
build:
Expand Down Expand Up @@ -52,3 +52,19 @@ jobs:

- name: Run tests
run: npm test

# Summary job that all matrix jobs must pass
# Used as the required status check in branch protection
test-summary:
name: Test Summary
runs-on: ubuntu-latest
needs: build
if: always()
steps:
- name: Check build matrix status
run: |
if [ "${{ needs.build.result }}" != "success" ]; then
echo "One or more build jobs failed"
exit 1
fi
echo "All build jobs passed successfully"
3 changes: 2 additions & 1 deletion deps/mpg123/src/output/coreaudio.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,8 @@ static OSStatus playProc(AudioConverterRef inAudioConverter,
/* Only play if we have data left */
if ( sfifo_used( &ca->fifo ) < (int)wanted ) {
if(!ca->decode_done) {
warning("Didn't have any audio data in callback (buffer underflow)");
// Commented out below warning because it floods stdout
// warning("Didn't have any audio data in callback (buffer underflow)");
return -1;
}
wanted = sfifo_used( &ca->fifo );
Expand Down