Upgrade typescript to 6.0.3 - #102
Merged
Merged
Conversation
TypeScript 7 (native Go compiler) is not viable yet: typescript-eslint has no release supporting it (programmatic Program API used by typescript-eslint is not implemented in the native compiler yet, hard crashes on lint). Upgraded to 6.0.3, the latest release on the JS-based (Strada) line, which typescript-eslint still supports. Since TS 6.0, @types packages are no longer auto-included by default unless referenced by an explicit import or listed in 'types'. The usb package's own .d.ts relies on ambient globals from @types/w3c-web-usb without importing/referencing it, so it silently stopped resolving (usb itself targets typescript ^6.0.3, so this is a config gap on our side, not a bug in usb). Added an explicit 'types: ["w3c-web-usb"]' to restore resolution without disabling lib checking project-wide. @types/node globals (process, Buffer, etc.) keep resolving fine without being listed since they're pulled in transitively via triple-slash references whenever a node builtin module is imported.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe project adds ChangesConfiguration updates
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
heavyrubberslave
added
patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit