fix: name canonical-vs-dotted contradiction, reject empty endorsements (confirmation-pass-1 chair rulings) - #49
Merged
Conversation
…s (confirmation-pass-1 chair rulings) Three chair rulings on the confirmation-pass-1 needs-a-look rows (ledger 2026-08-20): - _fold_expanded_answers: an expanding answer supplied both canonically and as dotted keys is a named problem instead of canonical silently winning — the contradicting dotted value used to vanish, the same silent-drop class #39/#40 named for rank slots - _parse_endorsements: a DELIBERATION with endorsements {} is a named definition problem — it satisfied the required check vacuously - collect_form_response: explicit "" collecting the default is KEPT and documented as the accept-the-default gesture (surfaces needing a clearable field must not prefill via default); behavior pinned by test Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
silversurfer562
force-pushed
the
claude/peaceful-haibt-0843bb
branch
from
August 20, 2026 13:18
cdd5e74 to
87f3bb2
Compare
# Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the three chair rulings on the confirmation-pass-1 needs-a-look rows for
bridge.py(ledger~/.attune/reports/roundtable/confirmation-pass-1-ledger-2026-08-20.md; rulings taken 2026-08-20).Rulings and changes
_fold_expanded_answersused to let a canonical answer ({"t": {...}}) silently win over a contradicting dotted sibling ("t.i2": "skip") — the same silent-drop class fix: name typed rank-slot collisions in the markdown ranking fold #39/fix: sweep fix batch — telemetry crash, prefill coercion, response_id collision, MCP schema drift #40 named for rank slots. A mixed shape is now a named validation problem listing the dotted keys. The markdown surface merges dotted rows into the canonical shape before handoff, so a mixed shape at collect time means a confused caller, not a typed reply.""collects the default — keep and document (ruled: keep). Empty is the accept-the-default gesture (enter through a prompt, an untouched widget); the bridge cannot distinguish a deliberately cleared prefill from an untouched one. Documented incollect_form_response's docstring; behavior pinned by a regression test.endorsements: {}— reject (ruled: name it). The empty mapping satisfied the required check vacuously, yielding exactly the "just a decision, no endorsements" the field's requirement exists to prevent. Now a named definition problem; options nobody endorsed remain allowed.Tests
test_bridge.py,test_triage_construct.py); new regressions for the ranking mixed shape, empty endorsements, and the kept empty-accepts-default contract.🤖 Generated with Claude Code