fix: guard the widget's :: radio-group namespace + skip empty-enum PROGRESS schema (confirmation-pass-2) - #55
Merged
Conversation
…PROGRESS in the elicitation schema (confirmation-pass-2)
Two confirmation-pass-2 needs-a-look findings (library review,
2026-08-20), recovered from uncommitted work in the main checkout.
- form_from_dict now rejects a field id that collides with a TRIAGE /
ASSUMPTION_REVIEW board's "a::<idx>" widget radio-group namespace,
symmetric with the existing dotted-key guard. A sibling field id
literally "a::1" shared a radio group's `name`, so the browser fused
the two into one mutually-exclusive group and a field became
unanswerable in the widget.
- A display-only PROGRESS field (no blocked options) no longer projects
to `{"type": "string", "enum": []}` in the elicitation schema — an
empty enum is a property no value can satisfy. Such a report is
narrated, not answered, so it is skipped from properties/required; a
PROGRESS carrying blocked options is a real single-pick and still
projects.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
silversurfer562
force-pushed
the
claude/forms-pass2-widget-guards
branch
from
August 20, 2026 13:08
c15ac32 to
ec065e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two confirmation-pass-2 needs-a-look findings (library review, 2026-08-20), recovered from uncommitted work found in the main checkout during a session sweep — the changes existed in no commit on any branch. Preserved here atomically.
::radio-group namespace guard —form_from_dictnow rejects a field id that collides with a TRIAGE / ASSUMPTION_REVIEW board'sa::<idx>widget radio-group namespace, symmetric with the existing dotted-key guard. A sibling field id literallya::1emitted a group sharing thatname, so the browser fused the two into one mutually-exclusive group and one field became unanswerable in the widget. Rejected at definition time so the colliding HTML is never rendered.{"type": "string", "enum": []}in the elicitation schema — an empty enum is a property no value can satisfy (unanswerable field / whole-schema rejection on a strict client). Such a report is narrated, not answered, so it is skipped fromproperties/required; a PROGRESS carrying blocked options is a real single-pick and still projects.Tests
Regressions in
test_triage_construct.pyandtest_elicitation_schema.py. Full suite: 681 passed.Source: confirmation-pass-2 needs-a-look ledger, 2026-08-20.
🤖 Generated with Claude Code